Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure logs returned by RPC match filter #507

Merged
merged 6 commits into from
Feb 10, 2025
Merged

fix: ensure logs returned by RPC match filter #507

merged 6 commits into from
Feb 10, 2025
+75 −12

Conversation

eshaan7
Copy link
Contributor

@eshaan7 eshaan7 commented Feb 6, 2025

No description provided.

ncitron
ncitron reviewed Feb 7, 2025
View reviewed changes
core/src/execution/errors.rs Outdated Show resolved Hide resolved
core/src/execution/mod.rs Show resolved Hide resolved
@eshaan7
Copy link
Contributor Author

eshaan7 commented Feb 10, 2025

@ncitron; addressed both comments in ce945c5. PTAL.

@eshaan7 eshaan7 requested a review from ncitron February 10, 2025 08:10
ncitron
ncitron approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 32f47de into a16z:master Feb 10, 2025
4 of 6 checks passed
@eshaan7 eshaan7 deleted the fix/logs-match-filter branch February 10, 2025 18:50
@eshaan7 eshaan7 mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaan7 @ncitron